-
Notifications
You must be signed in to change notification settings - Fork 2
Namsonx/task/stabi branch #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…_development Added inline Python code self test "JPP_2100"
…ation_maintenance_2 Documentation extended: Python inline code
(and already adapted to new syntax without 'eval' keyword)
…_docu Selftest development and documentation maintenance
* Tests are commented out * Expected results not yet defined Reason: Feature currently under construction
…_docu BADCASE tests of section INLINE_CODE added
…_docu Some INLINE_CODE testcases fixed
…_docu Extensions of selftest and documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds extensive test coverage for Python inline code functionality in the JsonPreprocessor. The PR introduces a new testing framework for generating and executing comprehensive test scenarios, particularly focusing on Python inline code features, both valid (GOODCASE) and invalid (BADCASE) usage patterns.
Key changes include:
- Added a new test snippet generation framework in
GenSnippetsJPP.pyto automatically create test cases - Introduced comprehensive test coverage for Python inline code with 570+ new test snippets
- Added new test files for inline code functionality with both positive and negative test cases
Reviewed Changes
Copilot reviewed 69 out of 70 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/testtools/GenSnippetsJPP.py | Enhanced test generation framework with new methods for Python inline code testing |
| test/testconfig/TestConfig.py | Added configuration for new inline code test cases (JPP_2100-2194) |
| test/pytest/pytestfiles/ | Added new pytest test files for inline code GOODCASE and BADCASE scenarios |
| test/testfiles/jpp-test_config_*.jsonp | Generated 95 new test files covering various inline code patterns |
| packagedoc/additional_docs/ | Updated documentation with Python inline code syntax and examples |
| test/*.txt, *.rst, *.html, *.csv | Updated test documentation files with new test case listings |
Comments suppressed due to low confidence (1)
test/testfiles/jpp-test_config_2161.jsonp:18
- Missing closing angle bracket '>>' in the Python inline code within the key name. The inline code appears to be malformed.
"<<(\"A\" if True else \"B\">>" : 1
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
HolQue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to me!
test-fullautomation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Son,
looks good to me!
Thank you,
Thomas
Pull-request for the Sprint-25.6.1